fix(metricsai): query reactors, not the removed users field, for review reactions - #50
Merged
Merged
Conversation
…ew reactions
The GraphQL reaction lookup for review summaries asked for ReactionGroup.users, a field GitHub removed in 2021, so the query errored and PyGithub raised — silently swallowed to (0,0).
Every review summary 👍/👎 was therefore dropped (a 👎 went uncounted). Switch to the current 'reactors { totalCount }' (with a 'users' fallback for old GHE) and add a regression test asserting 👎 maps to thumbs_down.
Co-Authored-By: Claude Opus 4.8 (1M context)
<noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #49. Review summary-level 👍/👎 were never counted: the GraphQL lookup requested
ReactionGroup.users, a field GitHub removed in 2021. The query errored, PyGithub raised, and theexceptturned it into(0,0)— so a thumbs-down on a submitted review was silentlydropped.
Fix
reactionGroups { content reactors { totalCount } }(the current field), with ausersfallback for old GitHub Enterprise.thumbs_down(notthumbs_up), plus a legacy-usersparse test.Verify
metricsai --debugno longer logsreview reactions lookup failed …for reviews carrying reactions, and a review's 👎 now incrementssecurity_thumbs_downs.🤖 Generated with Claude Code